Skip to content

[TEST] Remove laurentsenta from contributors list - #142

Closed
galargh wants to merge 11 commits into
masterfrom
galargh-patch-2
Closed

[TEST] Remove laurentsenta from contributors list#142
galargh wants to merge 11 commits into
masterfrom
galargh-patch-2

Conversation

@galargh

@galargh galargh commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Removed 'laurentsenta' from the list of contributors.

Summary

Why do you need this?

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

Removed 'laurentsenta' from the list of contributors.
@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User laurentsenta:
  - will leave the organization
  - will lose admin permission to base-x (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to docs (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to github-mgmt (public) through team ipdx
  - will lose admin permission to go-base32 (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-base36 (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-multiaddr (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-multiaddr-dns (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-multiaddr-fmt (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-multibase (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-multicodec (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-multigram (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-multihash (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-multistream (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to go-varint (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to java-multiaddr (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to java-multibase (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to java-multihash (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-blake2 (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-cid-tool (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-dns (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-mafmt (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-multiaddr (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-multiaddr-matcher (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-multiaddr-to-uri (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-multiformats (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-murmur3 (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-sha3 (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to js-uri-to-multiaddr (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to ma-pipe (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to multiaddr (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to multibase (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to multicodec (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to multiformats (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to multihash (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to multistream (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to multistream-select (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to py-multiaddr (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to py-multibase (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to py-multicodec (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to py-multihash (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to rust-cid (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to rust-multiaddr (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to rust-multibase (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to rust-multihash (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to specs (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to unsigned-varint (public) through teams ipdx, w3dt-stewards
  - will lose admin permission to website (public) through teams ipdx, w3dt-stewards

For the full access breakdown, inspect the Fix workflow summary or access report artifact.

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Before merge, verify that all the following plans are correct. After merge, Apply will regenerate the plans from the merged commit and continue only if they match.

Terraform plans

multiformats
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # github_membership.this["laurentsenta"] will be destroyed
  # (because key ["laurentsenta"] is not in for_each map)
  - resource "github_membership" "this" {
      - etag     = "W/\"723689bb1418855249bdeaad1039444bc9e11d78c6fac10a9946b6a375b5b2f1\"" -> null
      - id       = "multiformats:laurentsenta" -> null
      - role     = "member" -> null
      - username = "laurentsenta" -> null
    }

  # github_team_membership.this["ipdx:laurentsenta"] will be destroyed
  # (because key ["ipdx:laurentsenta"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"8fdd64bf5900ca09e31b41f07cbe8fec8b2748ee7640ca0d684fe497768f89b6\"" -> null
      - id       = "6630974:laurentsenta" -> null
      - role     = "member" -> null
      - team_id  = "6630974" -> null
      - username = "laurentsenta" -> null
    }

  # github_team_membership.this["w3dt-stewards:laurentsenta"] will be destroyed
  # (because key ["w3dt-stewards:laurentsenta"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"387260a9959feaa41c06405710c387509d1402b19bdc3af3ce7f16ca04080eff\"" -> null
      - id       = "4657016:laurentsenta" -> null
      - role     = "member" -> null
      - team_id  = "4657016" -> null
      - username = "laurentsenta" -> null
    }

Plan: 0 to add, 0 to change, 3 to destroy.

@galargh

galargh commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

TODO:

  • mention in the changelog that the access changes action has to be updated, otherwise people will get nested details and it will display funnyt
  • add checks for comment length in access changes comment, let's drop the less important parts if we cross github comment length limits
  • let's bring back the variable check in -allow-destroy environments, it is needed because the environments are created if they don't exist
  • the plan should fail if we're removing someone from an organization but they still are a member of some team or have direct access to a private repository
  • access changes should also note how one has access to a resource so instead of "has admin permission to repo", it should say something like "has admin permission to repo through team" or "has direct admin permission to repo"
  • access changes should flag members that have no repository access as potential no members - this includes those that are only part of a team without any additional repo access
  • in comments, we should only include access changes after all; the full breakdown explanation of access should be accessible in some other way, not on every PR - maybe a dedicated workflow will do
  • add 'reflect-metadata' to the top of classify script

Removed 'laurentsenta' from member and maintainer lists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant